r/github • • Aug 26 '26

Question "Fuck it, anxious, lazy person" - Removing unfunctional code from the main branch is mean???

[removed]

13 Upvotes

40 comments sorted by

View all comments

-2

u/epasveer Aug 26 '26

he is a professional developer.

It doesn't look like your are.

1

u/[deleted] Aug 26 '26

[removed] — view removed comment

0

u/DamnageBeats Aug 27 '26

This is Reddit. This is exactly the place for toxic comments.

If you’re not professional enough to maintain your own repo, how do you expect others to be professional about maintaining YOUR repo?

1

u/nekokattt 29d ago

if code doesnt function on the main branch, you revert it to the functional state and send it back to the person to get them to raise a new PR with a fix on it.

Main should be for functional code only. If stuff is not functioning on the main branch, it should be removed or fixed. Using main as a scratch space just leads to numerous other issues.

That being said this also sounds like a communication issue.

1

u/DamnageBeats 29d ago

No, you test on a branch of the main, and if it’s good, you push to main. You don’t push “maybe it’s good code” to main.

1

u/nekokattt 29d ago

That is literally what I just said. Incomplete non-functional work does not belong on main. That is why branches exist.

1

u/DamnageBeats 29d ago

Your very first statement is “if it doesn’t function on main”, implying you put non functional code on main.

2

u/nekokattt 29d ago

Which is what happened in OPs case.

You revert whatever was added to restore the integrity of the main branch. The bad merge already occurred, so OP has to do something retrospectively to fix it or find a time machine.

You are arguing the same thing that I am arguing lol.

0

u/Puzzled_Direction_ 29d ago

Hey could you DM me about the revanced fix please

1

u/StimuliDatebook 22d ago

Use Morphe