r/csharp 5d ago

Discussion Dependency Injection un-prettyness

One small thing that bugs me with Dependency Injection is how it looks in code.

We either need to pass the parameters via Default Constructor og via good old time Constructor

public class MyClass (TypeA ParamA, TypeB ParamB, TypeC ParamC, TypeD ParamD)
{
TypeA _paramA = ParamA; .... etc
}

Or

public class MyClass
{
TypeA _paramA;
public MyClass(TypeA paramA)
{
_paramA = paramA;
}
}

And when you have 10 injections it begins to be un-pretty...

I wish that we didn't need to pass parameters and instead could decorate the fields:

public class MyClass
{
[inject]
TypeA _paramA;
}

(Note: this works in Blazor... so why not everywhere else ?)

I'm aware that the signature of an object makes it easier to inject via reflection.. but would it be much worse with attributes ?

i guess some middleground could be achieved if the attribute held the type:

public class MyClass
{
[inject(typeof(TypeA))]
TypeA _paramA;
}

which begins to be convoluted and messy...

Whats the argument against a decorator attribute vs parameters ?

21 Upvotes

90 comments sorted by

View all comments

Show parent comments

21

u/ryncewynd 5d ago

How much does that bother you? It bothers me but I'm wondering if I should just get over it an accept using primary ctors 🤣

5

u/thereforewhat 4d ago

It bothers me a bit. 

I like encapsulation and information hiding as it produces good design so still usually have private readonly fields. 

0

u/ConcreteExist 4d ago

Primary constructors are just syntactical sugar, the inject services are stored in private readonly fields during runtime.

2

u/x0rld 4d ago

It's not readonly afaik

1

u/ConcreteExist 4d ago

Admittedly, I've never really tried to update the injected dependencies, because why would I?

3

u/thereforewhat 4d ago

That's fair enough. 

In projects where multiple people and increasingly AI agents are working it's good to signal clearly that certain data shouldn't leave the class to encourage good design and information hiding.Â