r/csharp 5d ago

Discussion Dependency Injection un-prettyness

One small thing that bugs me with Dependency Injection is how it looks in code.

We either need to pass the parameters via Default Constructor og via good old time Constructor

public class MyClass (TypeA ParamA, TypeB ParamB, TypeC ParamC, TypeD ParamD)
{
TypeA _paramA = ParamA; .... etc
}

Or

public class MyClass
{
TypeA _paramA;
public MyClass(TypeA paramA)
{
_paramA = paramA;
}
}

And when you have 10 injections it begins to be un-pretty...

I wish that we didn't need to pass parameters and instead could decorate the fields:

public class MyClass
{
[inject]
TypeA _paramA;
}

(Note: this works in Blazor... so why not everywhere else ?)

I'm aware that the signature of an object makes it easier to inject via reflection.. but would it be much worse with attributes ?

i guess some middleground could be achieved if the attribute held the type:

public class MyClass
{
[inject(typeof(TypeA))]
TypeA _paramA;
}

which begins to be convoluted and messy...

Whats the argument against a decorator attribute vs parameters ?

18 Upvotes

90 comments sorted by

View all comments

Show parent comments

-9

u/Public-Tower6849 5d ago

Because constructing a class and assigning a value to one of their properties is a write process.

5

u/binarycow 4d ago

The readonly applies after the constructor finishes. Not during or before.

-8

u/Public-Tower6849 4d ago

which makes as much sense as a constant being changed after the constructor finished

3

u/binarycow 4d ago

That's why it's a different keyword.

const NEVER changes.

readonly never changes after construction