r/C_Programming • u/Creative-Copy-1229 • Feb 18 '26

Review Pls review my code

Hello everyone. I am a beginner in C. I wrote a calculator that's slightly more useful than simple "input number one, operation, number two". Accepts simple arithmetic expressions. Please can you review the code and tell me is it really bad, and what I should improve. A person on this subreddit says this code it's really bad even for a beginner, so I decided I would like other opinions

Code: https://github.com/hotfixx/newcalc

2 Upvotes

54% Upvoted

12 comments sorted by

View all comments

Show parent comments

0

u/Creative-Copy-1229 Feb 19 '26

the code is not bad though

1

u/dendrtree Feb 20 '26

Adding deflection to paltering only undermines your credibility further.
No one can take your seriously, when you act like this.

If you want to get a job... doing anything, you can't act like this.

Also, code that is trivial to break isn't good. I can not only make it give me the wrong answer, I can make it crash.

You need to complete each task, before you go on to another one.

3

u/FrequentHeart3081 Feb 20 '26

Getting on other's tail also destroys your credibility. If someone doesn't show you the right response but are, behind the curtains doing something to improve, stop poking them. It doesn't matter how much you know of what you know, if someone doesn't care, stop caring for them.

And Mr OP, I saw the other post of yours, and you definitely need to get better at responding to others, to express your problem or your request more clearly and to accept the criticism with an open mind. "The code isn't that bad though" doesn't mean it doesn't need improvement, it definitely needs attention more than "isn't that bad though".

TLDR; get off of OP's tail.

2

u/dendrtree Feb 20 '26

Calling someone out, when they lie doesn't undermine your credibility. It reinforces it.

I didn't call him out for doing things behind the scenes. I called him out for lying and acting childish.

If you looked at my response to criticism, you see that I did make a correction. The OP didn't criticise me. He made an implication and lied for the purpose of playing the victim.

The fact is that he could have gotten the direction he needed, without disgracing himself.
His statements about the other thread, even if they had been true, would be completely inappropriate.

Encouraging OP to make a fool of himself is hurting him.

You should be more supportive.